Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser.y update for deprecated %pure-parser #370

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

mckellygit
Copy link
Contributor

Hi,
Thank you for libxkbcommon.
I get this when building -
../src/xkbcomp/parser.y:88.1-12: warning: deprecated directive: ‘%pure-parser’, use ‘%define api.pure’ [-Wdeprecated]
and changed parser.y to use newer method.
Not sure if changing causes more harm than good or if we can version this somehow.
I am using bison 3.5.1
thx

@bluetech
Copy link
Member

bluetech commented Aug 5, 2023

Yes this is annoying, the reason that I haven't changed it so far is that we also support byacc, which didn't support @define api.pure. BUT, I just checked again and

2023-05-16  Thomas E. Dickey  <[email protected]>
	* reader.c:
	recognize bison's "%define api.pure" as an alternative to "%pure-parser"

and a quick test shows that it works. So we can merge this, thanks!

@bluetech bluetech merged commit e7f02d3 into xkbcommon:master Aug 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants