Experiment: state: support pure virtual modifiers #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
state
|
Referencing #36 here too since there's significant overlap. |
|
Yeah, nice. I think this is definitely the right approach. |
Traditionally, virtual modifiers were merely name aliases for real modifiers,
e.g. NumLock was usually mapped to Mod2 (see modifier_map statement). Virtual
modifiers that were never mapped to a real one had no effect on the keymap state.
This patch introduces the concept of pure virtual modifiers, i.e. virtual
modifiers that are not mapped now show up as if the were true modifiers.
Note that pure virtual modifiers cannot be used in an interpret action's AnyOf()
and an interpret action for a pure virtual modifier must be AnyOfOrNone() to
take effect:
virtual_modifiers APureMod,...;
interpret a+AnyOfOrNone(all) {
virtualModifier= APureMod;
action= SetMods(modifiers=APureMod);
};
The above adds a pure virtual modifier for keysym `a`.
Interestingly, this fixes one current issue with our tests: previously the
de(neo) layout level5 didn't take effect correctly, with this patch in place it
now behaves.
wismill
force-pushed
the
wip/pure-virtual-modifiers
branch
from
52ad82a
to
0c66d0a
Compare
|
Rebased and added first dedicated tests. Since this has the potential to breaks things, I would proceed with care. But honestly I feel it looks pretty solid for now. Maybe modify more tests much like |
|
This will require #512 for a full implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally, virtual modifiers were merely name aliases for real modifiers, e.g. NumLock was usually mapped to Mod2 (see modifier_map statement). Virtual modifiers that were never mapped to a real one had no effect on the keymap state.
This patch introduces the concept of pure virtual modifiers, i.e. virtual modifiers that are not mapped now show up as if the were true modifiers.
Note that pure virtual modifiers cannot be used in an interpret action's AnyOf() and an interpret action for a pure virtual modifier must be AnyOfOrNone() to take effect:
The above adds a pure virtual modifier for keysym
a.Interestingly, this fixes one current issue with our tests: previously the de(neo) layout level5 didn't take effect correctly, with this patch in place it now behaves.
This took forever to wrap my head around it almost feels too simple now... The one test case failure was in the
de(neo)layout but after staring at this - it actually fixes that particular issue.Related to #447
cc @wismill, @bluetech, @fooishbar