Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Improve xkeyboard-config script #503

Merged
merged 1 commit into from
Nov 4, 2024
Merged

tests: Improve xkeyboard-config script #503

merged 1 commit into from
Nov 4, 2024

Conversation

wismill
Copy link
Member

@wismill wismill commented Sep 5, 2024

  • Refactor to more modern Python
  • Allow iterating over models too
  • Add filter for models and options
  • Add “short output” option

@wismill wismill added enhancement Indicates new feature requests testing Indicates a need for improvements or additions to testing labels Sep 5, 2024
@wismill wismill added this to the 1.8.0 milestone Sep 5, 2024
whot
whot reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments, none of which are very important

test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
@wismill wismill force-pushed the test/xkeyboard-config-test-enhancements branch from 73e1ce3 to ab679d3 Compare September 6, 2024 08:46
wismill
wismill commented Sep 6, 2024
View reviewed changes
Copy link
Member Author

@wismill wismill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored further. I would like to speed this up too.

test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
bluetech
bluetech reviewed Sep 8, 2024
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I read it all, just a couple drive-by comments...

test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
test/xkeyboard-config-test.py.in Outdated Show resolved Hide resolved
@wismill wismill force-pushed the test/xkeyboard-config-test-enhancements branch 2 times, most recently from bac19ab to 1663f8c Compare October 30, 2024 14:25
@wismill
tests: Improve xkeyboard-config script
e8a8067 
- Refactor to more modern Python
- Allow iterating over models too
- Add filter for models and options
- Add “short output” option
- Fix layout variant
- Use models subfolders for keymaps
- Allow to load multiple registries simultaneously
@wismill wismill force-pushed the test/xkeyboard-config-test-enhancements branch from 1663f8c to e8a8067 Compare October 30, 2024 14:42
@wismill wismill marked this pull request as ready for review October 30, 2024 14:44
@wismill wismill merged commit a8afe6f into xkbcommon:master Nov 4, 2024
4 checks passed
@wismill wismill deleted the test/xkeyboard-config-test-enhancements branch November 4, 2024 15:34
@wismill
Copy link
Member Author

wismill commented Nov 4, 2024

Merged, so we can use its new features in xkeyboard-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whot whot whot left review comments

@bluetech bluetech bluetech left review comments

Assignees
No one assigned
Labels
enhancement Indicates new feature requests testing Indicates a need for improvements or additions to testing
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wismill @bluetech @whot