Actions/locks xkb extension v3 #527
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymap: Add xkb_keymap_new_from_names2 Currently `xkb_keymap_new_from_names` does not allow to specify the keymap format, so provide a new function `xkb_keymap_new_from_names2`. keymap: Use explicit format in keymap_get_as_string actions: Use explicit format for parsing actions test: Use explicit format version in test_compile_rules tools: Add --format* options Allow to choose the exact keymap formats for parsing and serializing. This prepares for the addition of the new minor version XKB 1.1.
For now only an internal format.
This is an extension to XKB, to allow to use e.g. the combination `Control + Shift` *alone* to switch layouts, while keeping the use of `Control + Shift + some other key` (typically for keyboard shortcuts). This is really useful for people coming from other platform, such as Windows.
This is an extensions to XKB. It intends to allow to deactivate CapsLock on press rather than on release, as in other platforms such as Windows.
This is for experimental use only.
wismill
added
X11 legacy: limitations
|
I installed this on my system and will test in various situations. So far it’s working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of #485 (and of the first attempt #446, see #484 for the rational). The differences is that is it rebased on master and without exposing the new format
XKB_KEYMAP_FORMAT_TEXT_V1_1yet. We use an experimentalXKB_EXPERIMENTAL_LOCKSenvironment variable to activate it, until we agree on an API (see #484). Note that this is only temporary, in order to be able to test it in real conditions, without waiting for DE to enable configuration of the keymap format.In order to fix #372 and #420, one must set the env variable
XKB_EXPERIMENTAL_LOCKSto something, e.g.true.Additionally for #420, on must must also modify
/usr/share/xkb/symbols/group(preferably by overriding it via~/.config/xkb), that is use multiple actions thanks to #487:partial modifier_keys xkb_symbols "lctrl_lshift_toggle" { - key <LFSH> {[ Shift_L, ISO_Next_Group ], type[group1] = "PC_CONTROL_LEVEL2" }; + key <LFSH> {[ Shift_L, {Shift_L, ISO_Next_Group} ], type[group1] = "PC_CONTROL_LEVEL2" }; - key <LCTL> {[ Control_L, ISO_Next_Group ]}; + key <LCTL> {[ Control_L, {Control_L, ISO_Next_Group} ]}; }; partial modifier_keys xkb_symbols "lctrl_lshift_toggle_rev" { - key <LFSH> {[ Shift_L, ISO_Prev_Group ], type[group1] = "PC_CONTROL_LEVEL2" }; + key <LFSH> {[ Shift_L, {Shift_L,ISO_Prev_Group} ], type[group1] = "PC_CONTROL_LEVEL2" }; - key <LCTL> {[ Control_L, ISO_Prev_Group ]}; + key <LCTL> {[ Control_L, {Control_L,ISO_Prev_Group} ]}; }; partial modifier_keys xkb_symbols "rctrl_rshift_toggle" { - key <RTSH> {[ Shift_R, ISO_Next_Group ], type[group1] = "PC_CONTROL_LEVEL2" }; + key <RTSH> {[ Shift_R, {Shift_R,ISO_Next_Group} ], type[group1] = "PC_CONTROL_LEVEL2" }; - key <RCTL> {[ Control_R, ISO_Next_Group ]}; + key <RCTL> {[ Control_R, {Control_R,ISO_Next_Group} ]}; };Changes:
XKB_KEYMAP_FORMAT_TEXT_V1_1lockOnReleaseforLockGroup. It locks the group on release rather than press as in the protocol. Intended to fix issue for group lock on e.g.shift+alt. It is the default forXKB_KEYMAP_FORMAT_TEXT_V1_1, so that it fixes the issue with thexkeyboard-configfiles unchanged.unlockOnPressforLockMods. It unlocks the modifiers on second press rather than the second release, as in the protocol. Intended to fix issue withCapsLockfor fast typists. It is the default forXKB_KEYMAP_FORMAT_TEXT_V1_1, so that it fixes the issue with thexkeyboard-configfiles unchanged.--formatoptions to tools, in order to select the keymap format for parsing and serializing.A lot of files are affected, but hopefully it is easier to review per commit. The first commit should be in an independent PR (hence the WIP title).
TODO:
@whot @bluetech @fooishbar