Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add doc test #904

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(ci): add doc test #904

merged 1 commit into from
Jul 29, 2024

Conversation

lxl66566
Copy link
Collaborator

@lxl66566 lxl66566 commented Jul 19, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    • ci does not test doc
  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    • no

@mergify mergify bot requested a review from a team July 19, 2024 04:25
Copy link

mergify bot commented Jul 19, 2024

@lxl66566 You've modified the workflows. Please don't forget to update the .mergify.yml.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (e35b35a) to head (7bddb88).
Report is 158 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   75.55%   76.09%   +0.54%     
==========================================
  Files         180      189       +9     
  Lines       26938    28904    +1966     
  Branches    26938    28904    +1966     
==========================================
+ Hits        20353    21995    +1642     
- Misses       5366     5565     +199     
- Partials     1219     1344     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request.yml Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 19, 2024 06:45
@lxl66566 lxl66566 force-pushed the test branch 2 times, most recently from c267446 to 3b22138 Compare July 19, 2024 09:05
Copy link

mergify bot commented Jul 19, 2024

@lxl66566 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft July 19, 2024 09:15
@mergify mergify bot added the CI:fail CI has failed label Jul 19, 2024
Signed-off-by: lxl66566 <[email protected]>
@mergify mergify bot marked this pull request as ready for review July 19, 2024 11:09
@mergify mergify bot removed the CI:fail CI has failed label Jul 19, 2024
@bsbds bsbds merged commit 5bf41d2 into xline-kv:master Jul 29, 2024
18 checks passed
@mergify mergify bot requested a review from a team July 29, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants