Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update luau to 0.638 #4908

Merged
merged 8 commits into from
Aug 24, 2024
Merged

Update luau to 0.638 #4908

merged 8 commits into from
Aug 24, 2024

Conversation

SirLynix
Copy link
Member

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@Chi-EEE
Copy link
Contributor

Chi-EEE commented Aug 17, 2024

mingw can be fixed by using this patch on isocline which is embedded in the project: https://github.com/xmake-io/xmake-repo/blob/dev/packages/i/isocline/xmake.lua#L13

@SirLynix
Copy link
Member Author

Thank you.

I don't know why android broke from nowhere now, maybe a xmake change?

@star-hengxing
Copy link
Contributor

Android r27 seems to break some packages.

@SirLynix
Copy link
Member Author

the fix for android seems to be to require at least cmake 3.6: android/ndk#2032

@c8ef
Copy link
Member

c8ef commented Aug 22, 2024

Note that vcpkg suffers from the same issue: microsoft/vcpkg#40339

If too many packages are affected by the CI update, I agree to roll back the NDK version update. Alternatively, we can merge this first and wait before making a decision.

Copy link
Member

@c8ef c8ef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now. I will send the necessary patch to the upstream.

@waruqi waruqi merged commit 063862d into dev Aug 24, 2024
65 checks passed
@waruqi waruqi deleted the SirLynix-patch-2 branch August 24, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants