feat: Adds AllowGroup and DenyGroup messages #146
Conversation
| repeated string wallet_addresses = 1; | ||
| // Add the given group_ids to the block list | ||
| repeated string group_ids = 2; |
There was a problem hiding this comment.
I think we are going to want a separate action for these, rather than a second field in the existing action. Otherwise you could specify both in the same action, which is confusing.
We can safely rename the existing type names to something like AllowDM for clarity (although all our SDKs will have to update their import statements)
There was a problem hiding this comment.
Sure. I updated to pull out AllowGroup and BlockGroupDenyGroup into their own message types.
and renamed Allow to AllowDM and Block to BlockDMDenyDM. I'll update the SDK side next.
tuddman
changed the title
| // Grant Group access | ||
| message AllowGroup { | ||
| // Add the given group_ids to the allow list | ||
| repeated string group_ids = 2; |
There was a problem hiding this comment.
group_ids should repeated bytes
tuddman
force-pushed
the
st/group-preference-actions
branch
from
2efa639
to
dd3e754
Compare
tuddman
changed the title
|
🎉 This PR is included in version 3.43.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
AllowtoAllowAddressBlocktoDenAddressAllowGroupmessage typeDenyGroupmessage type