Upgrade to node 18.19.0 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rygine
commented
Feb 14, 2024
| 5, 85, 84, 70, 45, 56, 40, 0, 34, 48, 120, 156, 51, 52, 48, 209, 49, 52, | ||
| 48, 212, 49, 52, 176, 128, 96, 67, 67, 29, 99, 35, 29, 67, 67, 75, 48, | ||
| 211, 208, 208, 4, 42, 101, 0, 22, 30, 85, 61, 170, 122, 84, 53, 237, 85, | ||
| 3, 0, 139, 43, 173, 229, | ||
| ]) |
There was a problem hiding this comment.
i'm not sure why this is necessary. i couldn't find anything in the node release notes that may have changed CompressionStream or DecompressionStream.
neekolas
approved these changes
Feb 14, 2024
neekolas
reviewed
Feb 14, 2024
| @@ -2,7 +2,7 @@ import { ciphertext } from '@xmtp/proto' | |||
| import Ciphertext, { AESGCMNonceSize, KDFSaltSize } from './Ciphertext' | |||
| import crypto from './crypto' | |||
|
|
|||
| const hkdfNoInfo = new ArrayBuffer(0) | |||
| const hkdfNoInfo = new Uint8Array().buffer | |||
rygine
force-pushed
the
rygine/update-node-version
branch
from
57581c0
to
b623ec5
Compare
Deploying with
|
| Latest commit: |
b623ec5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73d4e004.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-update-node-version.xmtp-js.pages.dev |
|
🎉 This PR is included in version 11.3.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR:
18.19.0checkoutandsetup-nodeactions tov4ArrayBufferwith buffer of emptyUint8Arrayas of node 18.17.0...
link to PR for more context: nodejs/node#46067
with this change, the
crypto.subtle.deriveKeyfunction started complaining that an emptyArrayBufferwas not actually an instance of anArrayBuffer. to fix this error, i simply instantiate an emptyUint8Arrayand use its buffer as the value for theinfoparameter. the values are equivalent (both empty array buffers).