Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake some tests #156

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Deflake some tests #156

merged 5 commits into from
Oct 12, 2022

Conversation

snormore
Copy link
Contributor

@snormore snormore commented Oct 11, 2022

Deflake the following classes of test failures:

--- FAIL: TestStoreClient_Query (0.00s)
    --- FAIL: TestStoreClient_Query/with_paging_cursor_backward (0.02s)
        store.go:21:
            	Error Trace:	store.go:21
            	            				store_test.go:44
            	            				client_test.go:334
            	Error:      	Received unexpected error:
            	            	ERROR: database "test_elsrr" already exists (SQLSTATE=42P04)
            	Test:       	TestStoreClient_Query/with_paging_cursor_backward


--- FAIL: TestE2E (0.00s)
    --- FAIL: TestE2E/messagev1_publish_subscribe_query (0.03s)
        e2e_test.go:34:
            	Error Trace:	e2e_test.go:34
            	Error:      	Received unexpected error:
            	            	401 Unauthorized: {"code":16, "message":"validating token: token timestamp is in the future", "details":[]}
            	            	publishing
            	            	github.com/xmtp/xmtp-node-go/pkg/e2e.(*Suite).testMessageV1PublishSubscribeQuery
            	            		/Users/snormore/Workspace/xmtp-node-go/pkg/e2e/test_messagev1.go:66
            	            	github.com/xmtp/xmtp-node-go/pkg/e2e.TestE2E.func1
            	            		/Users/snormore/Workspace/xmtp-node-go/pkg/e2e/e2e_test.go:33
            	            	testing.tRunner
            	            		/opt/homebrew/Cellar/[email protected]/1.18.6/libexec/src/testing/testing.go:1439
            	            	runtime.goexit
            	            		/opt/homebrew/Cellar/[email protected]/1.18.6/libexec/src/runtime/asm_arm64.s:1270
            	Test:       	TestE2E/messagev1_publish_subscribe_query

@snormore snormore requested a review from a team October 11, 2022 16:17
pkg/api/authentication_test.go Outdated Show resolved Hide resolved
pkg/testing/store.go Show resolved Hide resolved
pkg/api/authentication.go Show resolved Hide resolved
pkg/api/setup_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mkobetic mkobetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@snormore snormore merged commit bd2842e into main Oct 12, 2022
@snormore snormore deleted the deflake-some-tests branch October 12, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants