Decouple MLS messages from messagev1 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neekolas
reviewed
Jan 11, 2024
neekolas
reviewed
Jan 11, 2024
neekolas
reviewed
Jan 11, 2024
neekolas
reviewed
Jan 11, 2024
neekolas
reviewed
Jan 12, 2024
neekolas
reviewed
Jan 12, 2024
neekolas
reviewed
Jan 12, 2024
neekolas
reviewed
Jan 12, 2024
neekolas
reviewed
Jan 12, 2024
snormore
force-pushed
the
snor/mls-msgs
branch
from
078df42
to
fb4f2fa
Compare
snormore
force-pushed
the
snor/mls-msgs
branch
2 times, most recently
from
b3c3840
to
b3ede34
Compare
snormore
force-pushed
the
snor/mls-msgs
branch
from
b3ede34
to
ad3aa9e
Compare
snormore
commented
Jan 15, 2024
snormore
force-pushed
the
snor/mls-msgs
branch
from
ce8abec
to
51798be
Compare
neekolas
reviewed
Jan 19, 2024
neekolas
approved these changes
Jan 19, 2024
snormore
added a commit
that referenced
this pull request
Jan 23, 2024
* Separate MLS messages and implement service methods
* fix: group id and installation id are bytes
* fix: idempotent send group/welcome messages via uniquness in db
* fix: hex decode group id from mls validation service
* fix: s/Cursor/IdCursor
* fix: pass message data only in send group message request
* refactor: add mls {Group,Welcome}MessageInput types for send requests
* refactor: s/installation_id/installation_key in mls/api
* fix: clean up mls query page size logic
* feat: implement mls subscribe group/welcome messages
* Hex encode group ID
* fix: remove duplicate import
* fix: return grpc invalidargument on invalid group id
---------
Co-authored-by: Nicholas Molnar <[email protected]>
neekolas
added a commit
that referenced
this pull request
Jan 23, 2024
* Validation service scaffold (#320) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Add more MLS methods (#321) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Add a bunch of new endpoints * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Fix pointer to key package * Capitalize more things * Update server fields * Add test for sort methods * Save change to capitalization * Fix lint warnings * Fix problem with mocks * Fix index name * Move sorting to the store * Fix ciphertext validation * Make installation_id bytes * Add missing credential identity * Hack sql in query * Revert "Hack sql in query" This reverts commit 168b78a. * Remove custom type * Update to latest protos * Add CredentialIdentity * Fix migrations * refactor: walletaddress->accountaddress (#325) Settling on consistent terminology as discussed * go mod tidy * Assume KeyPackages are always last resort. (#329) * Assume KeyPackages are always last resort. * Missing KeyPackages don't cause entire request to fail. * Update go.mod * UpdateKeyPackage returns an error if installation is unknown. * refactor: move api/message/v3 to mls/api/v1 (#332) * refactor: move message_api/v3 to mls/api/v1 * refactor: move pkg/mlsstore to pkg/mls/store * Rename mls build/push workflow * Decouple MLS messages from messagev1 (#333) * Separate MLS messages and implement service methods * fix: group id and installation id are bytes * fix: idempotent send group/welcome messages via uniquness in db * fix: hex decode group id from mls validation service * fix: s/Cursor/IdCursor * fix: pass message data only in send group message request * refactor: add mls {Group,Welcome}MessageInput types for send requests * refactor: s/installation_id/installation_key in mls/api * fix: clean up mls query page size logic * feat: implement mls subscribe group/welcome messages * Hex encode group ID * fix: remove duplicate import * fix: return grpc invalidargument on invalid group id --------- Co-authored-by: Nicholas Molnar <[email protected]> * Generate protos in repo (#335) * Add buf.gen.yaml * Gen protos * Update build steps * Update protos * Add hpke pub key * Specify column * Fix field name * Fix migration * Add data to test * Do more validations on welcome messages * Simplify check * Fix insert statement * Push up mls image * Add new generated file --------- Co-authored-by: Richard Hua <[email protected]> Co-authored-by: Steven Normore <[email protected]> Co-authored-by: Brendan McMillion <[email protected]> Co-authored-by: Steven Normore <[email protected]>
snormore
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Validation service scaffold (#320) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Add more MLS methods (#321) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Add a bunch of new endpoints * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Fix pointer to key package * Capitalize more things * Update server fields * Add test for sort methods * Save change to capitalization * Fix lint warnings * Fix problem with mocks * Fix index name * Move sorting to the store * Fix ciphertext validation * Make installation_id bytes * Add missing credential identity * Hack sql in query * Revert "Hack sql in query" This reverts commit 168b78a. * Remove custom type * Update to latest protos * Add CredentialIdentity * Fix migrations * refactor: walletaddress->accountaddress (#325) Settling on consistent terminology as discussed * go mod tidy * Assume KeyPackages are always last resort. (#329) * Assume KeyPackages are always last resort. * Missing KeyPackages don't cause entire request to fail. * Update go.mod * UpdateKeyPackage returns an error if installation is unknown. * refactor: move api/message/v3 to mls/api/v1 (#332) * refactor: move message_api/v3 to mls/api/v1 * refactor: move pkg/mlsstore to pkg/mls/store * Rename mls build/push workflow * Decouple MLS messages from messagev1 (#333) * Separate MLS messages and implement service methods * fix: group id and installation id are bytes * fix: idempotent send group/welcome messages via uniquness in db * fix: hex decode group id from mls validation service * fix: s/Cursor/IdCursor * fix: pass message data only in send group message request * refactor: add mls {Group,Welcome}MessageInput types for send requests * refactor: s/installation_id/installation_key in mls/api * fix: clean up mls query page size logic * feat: implement mls subscribe group/welcome messages * Hex encode group ID * fix: remove duplicate import * fix: return grpc invalidargument on invalid group id --------- Co-authored-by: Nicholas Molnar <[email protected]> * Generate protos in repo (#335) * Add buf.gen.yaml * Gen protos * Update build steps * go mod tidy * Remove push-mls github workflow * Add hpke public key (#337) * Validation service scaffold (#320) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Add more MLS methods (#321) * Scaffold MLS server * Update go.mod * Fix missing argument * Add unsaved file * Lint * Working end-to-end * Lint * Add new push action * Add a bunch of new endpoints * Address review comments * Change method casing * Change casing of server options * Change casing of validation options * Remove unused function * Remove double pointer * Make private again * Fix pointer to key package * Capitalize more things * Update server fields * Add test for sort methods * Save change to capitalization * Fix lint warnings * Fix problem with mocks * Fix index name * Move sorting to the store * Fix ciphertext validation * Make installation_id bytes * Add missing credential identity * Hack sql in query * Revert "Hack sql in query" This reverts commit 168b78a. * Remove custom type * Update to latest protos * Add CredentialIdentity * Fix migrations * refactor: walletaddress->accountaddress (#325) Settling on consistent terminology as discussed * go mod tidy * Assume KeyPackages are always last resort. (#329) * Assume KeyPackages are always last resort. * Missing KeyPackages don't cause entire request to fail. * Update go.mod * UpdateKeyPackage returns an error if installation is unknown. * refactor: move api/message/v3 to mls/api/v1 (#332) * refactor: move message_api/v3 to mls/api/v1 * refactor: move pkg/mlsstore to pkg/mls/store * Rename mls build/push workflow * Decouple MLS messages from messagev1 (#333) * Separate MLS messages and implement service methods * fix: group id and installation id are bytes * fix: idempotent send group/welcome messages via uniquness in db * fix: hex decode group id from mls validation service * fix: s/Cursor/IdCursor * fix: pass message data only in send group message request * refactor: add mls {Group,Welcome}MessageInput types for send requests * refactor: s/installation_id/installation_key in mls/api * fix: clean up mls query page size logic * feat: implement mls subscribe group/welcome messages * Hex encode group ID * fix: remove duplicate import * fix: return grpc invalidargument on invalid group id --------- Co-authored-by: Nicholas Molnar <[email protected]> * Generate protos in repo (#335) * Add buf.gen.yaml * Gen protos * Update build steps * Update protos * Add hpke pub key * Specify column * Fix field name * Fix migration * Add data to test * Do more validations on welcome messages * Simplify check * Fix insert statement * Push up mls image * Add new generated file --------- Co-authored-by: Richard Hua <[email protected]> Co-authored-by: Steven Normore <[email protected]> Co-authored-by: Brendan McMillion <[email protected]> Co-authored-by: Steven Normore <[email protected]> * Populate options from MLS_DB_CONNECTION_STRING too --------- Co-authored-by: Nicholas Molnar <[email protected]> Co-authored-by: Richard Hua <[email protected]> Co-authored-by: Brendan McMillion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319