Add V3 rate limits #395
Draft
Add V3 rate limits #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Add specific rate limiting rules for V3. Summary of the rules:
IDENTITY_PUBLISHlimit that is specific to thePublishIdentityUpdatewith a much lower rate limit to deter bulk account creation.Potential issues
The super low identity rate limit might catch us in tests. We can turn off all rate limiting when running against localhost, which will help prevent issues. But any tests that run against the dev network will be subject to the limit so those tests will need to be highly restricted.