Remove inbox validation for uploading key packages #400
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
force-pushed
the
08-13-loosen_validations_for_key_package_uploads
branch
from
2404937
to
49ddb76
Compare
| @@ -2,5 +2,5 @@ | |||
| set -e | |||
|
|
|||
| function docker_compose() { | |||
| docker-compose -f dev/docker/docker-compose.yml -p xmtpd "$@" | |||
| docker compose -f dev/docker/docker-compose.yml -p xmtpd "$@" | |||
There was a problem hiding this comment.
Apparently our Github runners have been upgraded to a new version where docker-compose no longer exists as a separate command. You must use docker compose instead.
neekolas
force-pushed
the
08-13-loosen_validations_for_key_package_uploads
branch
from
49ddb76
to
a816114
Compare
| @@ -130,17 +130,17 @@ func (s *Service) Publish(ctx context.Context, req *proto.PublishRequest) (*prot | |||
| log.Debug("received message") | |||
|
|
|||
| if len(env.ContentTopic) > MaxContentTopicNameSize { | |||
| return nil, status.Errorf(codes.InvalidArgument, "topic length too big") | |||
| return nil, status.Error(codes.InvalidArgument, "topic length too big") | |||
There was a problem hiding this comment.
Our linter has apparently become more fussy with some version upgrade and this old code was causing lint fails
neekolas
force-pushed
the
08-13-loosen_validations_for_key_package_uploads
branch
2 times, most recently
from
81914f6
to
8fdef23
Compare
| @@ -96,17 +96,17 @@ func (wa *WalletAuthorizer) requiresAuthorization(req interface{}) bool { | |||
| func (wa *WalletAuthorizer) getWallet(ctx context.Context) (types.WalletAddr, error) { | |||
| md, ok := metadata.FromIncomingContext(ctx) | |||
| if !ok { | |||
| return "", status.Errorf(codes.Unauthenticated, "metadata is not provided") | |||
| return "", status.Error(codes.Unauthenticated, "metadata is not provided") | |||
There was a problem hiding this comment.
Stricter linting updates again
neekolas
force-pushed
the
08-13-loosen_validations_for_key_package_uploads
branch
from
8fdef23
to
ec2480f
Compare
| * | ||
| DEPRECATED: Use UploadKeyPackage instead | ||
| * | ||
| */ | ||
| func (s *Service) RegisterInstallation(ctx context.Context, req *mlsv1.RegisterInstallationRequest) (*mlsv1.RegisterInstallationResponse, error) { |
There was a problem hiding this comment.
We don't really need a separate endpoint for registering an installation and updating the key package. Can just do a "create or update" query and have one endpoint for everything.
| InstallationId []byte | ||
| Expiration uint64 | ||
| } | ||
|
|
||
| func (s *MLSValidationServiceImpl) ValidateInboxIdKeyPackages(ctx context.Context, keyPackages [][]byte) ([]InboxIdValidationResult, error) { |
There was a problem hiding this comment.
Should this just be ValidateKeyPackages now?
There was a problem hiding this comment.
I have some items further down in the tracking issue for cleaning up dead code and renaming things. Didn't want to do too much at once
tl;dr
PublishIdentityUpdateis calledAI Assisted Summary
This pull request includes several changes to the project, primarily focused on refactoring the installation registration process and updating the database schema. The key changes made are:
inbox_idandexpirationcolumns from theinstallationstable.UpdateKeyPackagequery and the addition ofCreateOrUpdateInstallationquery with upsert logic.RegisterInstallationmethod in favor ofUploadKeyPackage.ValidateInboxIdKeyPackagesmethod by removing intermediate validation requests and leveraging direct validation responses.These changes aim to streamline the installation registration process, reduce database schema complexity, and improve overall code maintainability.