Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice to not display spinner while waiting for process to terminate #3

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

djmattyg007
Copy link
Contributor

Displaying a spinner to the user is not always desirable, such as when
code is being called as part of an automatic script rather than purely
for a command line application. This lets the user choose whether or not
the spinner should be displayed.

…inate

Displaying a spinner to the user is not always desirable, such as when
code is being called as part of an automatic script rather than purely
for a command line application. This lets the user choose whether or not
the spinner should be displayed.
@coveralls
Copy link

coveralls commented Dec 28, 2016

Coverage Status

Coverage decreased (-0.3%) to 91.508% when pulling 503ae7d on djmattyg007:improve_spinner_control into 856da2f on xolox:dev.

@xolox xolox merged commit 503ae7d into xolox:dev Jan 10, 2017
xolox added a commit that referenced this pull request Jan 10, 2017
xolox added a commit that referenced this pull request Jan 10, 2017
@xolox
Copy link
Owner

xolox commented Jan 10, 2017

Hi Matthew and thanks for the pull request! I've merged your changes but made some modifications in the process, specifically executor now uses Spinner(interactive=False) when use_spinner is False, this disables the rendering of the spinner without requiring an if/else construct in wait_for_process() to avoid the spinner's with block.

@djmattyg007
Copy link
Contributor Author

Awesome :) Thanks, and thank you for all of your python packages, they're all superb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants