Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-ci): add docker image build #181

Merged
merged 3 commits into from
Aug 15, 2023
Merged

feat(github-ci): add docker image build #181

merged 3 commits into from
Aug 15, 2023

Conversation

nefelim4ag
Copy link
Contributor

Added CI to build a docker image on the tag

@bdovaz
Copy link
Collaborator

bdovaz commented Mar 13, 2023

@nefelim4ag you should also generate an image for arm64 because it is perfectly compatible.

@nefelim4ag
Copy link
Contributor Author

Yep, your point is correct, but I tried to do that and got a compilation error on arm, so I only suggest that will works
https://github.com/Nefelim4ag/UnityNuGet/actions/runs/4378154627/jobs/7662531497#step:7:413

@bdovaz
Copy link
Collaborator

bdovaz commented Mar 13, 2023

Related dotnet/sdk#27190

@bdovaz
Copy link
Collaborator

bdovaz commented Mar 20, 2023

@nefelim4ag it looks like they are going to fix it in 7.0.300: dotnet/dotnet-docker#4388 (comment)

That issue will be fixed shortly.

@bdovaz
Copy link
Collaborator

bdovaz commented Jun 14, 2023

@nefelim4ag
Copy link
Contributor Author

nefelim4ag commented Jun 15, 2023

buildx & github use qemu underneath, but i will add arm64 to test
And repo still uses the previous .Net version.

@nefelim4ag
Copy link
Contributor Author

@nefelim4ag
Copy link
Contributor Author

7.0.304 - same problem

@nefelim4ag
Copy link
Contributor Author

@bdovaz I switched the build to 8.0-preview and it looks like it fixed the problem.
I tested the image on the amd64 & arm64 machines at least it runs and looks like works.

@bdovaz
Copy link
Collaborator

bdovaz commented Aug 13, 2023

@nefelim4ag you forgot to use the TARGETARCH parameter, try it now with the changes I have added.

@nefelim4ag
Copy link
Contributor Author

nefelim4ag commented Aug 14, 2023

Yep, it's works
https://github.com/Nefelim4ag/UnityNuGet/actions/runs/5858676520/job/15883096146

And run successfully on arm

@bdovaz bdovaz merged commit 2148d93 into xoofx:master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants