Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HotChocolate and StrawberryShake packages. #387

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vrenken
Copy link
Contributor

@vrenken vrenken commented Jul 23, 2024

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/XXX
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
    Checked on nuget.org.
  • The lowest version added must be the lowest .NETStandard2.0 version available
    Searched for oldest netstandard2.0 package on nuget.org.
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    Running in customer projects using copied assemblies.
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    All dependencies are available from this NuGet feed - tested by accessing the feed through openUPM.
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@vrenken vrenken closed this Jul 29, 2024
@vrenken vrenken reopened this Jul 29, 2024
@bdovaz
Copy link
Collaborator

bdovaz commented Aug 21, 2024

Who uses these dependencies?

  • Microsoft.AspNetCore.WebUtilities
  • Microsoft.Net.Http.Headers

Because I see they are problematic, in versions > 2 they are not compatible with .NET Standard 2.0.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants