Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing modules dynamically and support for external modules #18

Closed
2 tasks done
rojvv opened this issue Jan 30, 2022 · 0 comments · Fixed by #27
Closed
2 tasks done

Importing modules dynamically and support for external modules #18

rojvv opened this issue Jan 30, 2022 · 0 comments · Fixed by #27
Assignees
@rojvv
Labels
feat

Comments

@rojvv
Copy link
Collaborator

rojvv commented Jan 30, 2022 •
edited
Loading

To make our built-in modules clean, we should import them dynamically instead of importing them one by one. Also, we need to make the bot extensible by adding the support to install external modules.

And this must be done with ES features, not CJS.
@rojvv rojvv added this to the v1.0.0-beta.1 milestone Jan 30, 2022
@rojvv rojvv added the feat label Jan 30, 2022
@rojvv rojvv self-assigned this Jan 30, 2022
rojvv added a commit that referenced this issue Feb 2, 2022
@rojvv
feat: external modules
711b82e 
- Closes #18.
@rojvv rojvv mentioned this issue Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rojvv rojvv

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: external modules xorgram/xor
1 participant
@rojvv