Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install built-in modules in a way that works when running from main.ts with URL #224

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

rojvv
Copy link
Collaborator

@rojvv rojvv commented Jul 22, 2022

Closes #223

@rojvv rojvv requested a review from ArnabXD July 22, 2022 15:30
@rojvv rojvv requested a review from dcdunkan July 22, 2022 15:31
Copy link
Member

@ArnabXD ArnabXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dcdunkan dcdunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rojvv rojvv merged commit fcd508d into main Jul 22, 2022
@rojvv rojvv deleted the fix-built-in-modules-when-running-from-url branch July 22, 2022 16:07
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants