Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): allow edit for eval #246

Merged
merged 1 commit into from
Aug 23, 2022
Merged

feat(util): allow edit for eval #246

merged 1 commit into from
Aug 23, 2022

Conversation

dcdunkan
Copy link
Member

No description provided.

@dcdunkan dcdunkan requested review from rojvv and ArnabXD August 23, 2022 19:20
@rojvv rojvv changed the title feat: support editing message in \eval feat(util): allow edit for \eval Aug 23, 2022
@rojvv rojvv changed the title feat(util): allow edit for \eval feat(util): allow edit for eval Aug 23, 2022
Copy link
Collaborator

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

@rojvv rojvv merged commit 518917f into main Aug 23, 2022
@rojvv rojvv deleted the feat-eval-edit branch August 23, 2022 19:31
rojvv pushed a commit that referenced this pull request Jan 20, 2023
rojvv pushed a commit that referenced this pull request Jan 20, 2023
rojvv pushed a commit that referenced this pull request Jan 20, 2023
rojvv pushed a commit that referenced this pull request Jan 20, 2023
rojvv pushed a commit that referenced this pull request Jan 20, 2023
rojvv pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants