Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description on emon_analog_sensor.h not correct #601

Closed
gnkarn opened this issue Feb 24, 2018 · 2 comments
Closed

Description on emon_analog_sensor.h not correct #601

gnkarn opened this issue Feb 24, 2018 · 2 comments
Assignees
@xoseperez
Labels
bug sensors
Milestone
1.12.4

Comments

@gnkarn
Copy link

gnkarn commented Feb 24, 2018

it is my understanding that this description is not right , at least not always
the analog input is not Gpio0 .

// Descriptive name of the sensor
String description() {
return String("EMON @ ANALOG @ GPIO0");
}
xoseperez added a commit that referenced this issue Feb 26, 2018
@xoseperez
Fix AnalogSensor description (#601)
32373f8
@xoseperez
Copy link
Owner

You are right. I have fixed the description.

@xoseperez xoseperez self-assigned this Feb 26, 2018
@xoseperez xoseperez added this to the 1.12.4 milestone Feb 26, 2018
@xoseperez
Copy link
Owner

This is staged for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoseperez xoseperez

Labels
bug sensors
Projects
None yet
Milestone
1.12.4
Development

No branches or pull requests
2 participants
@xoseperez @gnkarn