Use string interpolation instead of string concatenation #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekid
commented
Aug 20, 2023
| @@ -113,7 +113,7 @@ protected function emit() { | |||
| * @return void | |||
| */ | |||
| protected function emitOperator($result, $operator) { | |||
| throw new IllegalStateException('Unexpected operator '.$operator->value.' at line '.$operator->line); | |||
| throw new IllegalStateException("Unexpected operator {$operator->value} at line {$operator->line}"); | |||
There was a problem hiding this comment.
The latter is definitely more readable, we might want to keep this even if we decide not to merge this entire pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should theoretically improve speed - however, the effect is not measurable in the XP Compiler:
Best run before
Best run after