Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensure() #111

Merged
merged 2 commits into from
Dec 20, 2015
Merged

Remove ensure() #111

merged 2 commits into from
Dec 20, 2015

Conversation

thekid
Copy link
Member

@thekid thekid commented Dec 20, 2015

This pull request removes the deprecated ensure functionality which has been replaced by finally. See XP RFC 0298

Bumps version from 6.8.1-dev -> 6.9.0-dev
@thekid thekid added this to the 6.9.0 milestone Dec 20, 2015
@thekid
Copy link
Member Author

thekid commented Dec 20, 2015

Packages this will affect:

$ grep -Hirn 'ensure(' ../*/src/
../compiler/src/test/php/net/xp_lang/tests/RunnerTest.class.php:29:    } ensure($t); {
../ftp/src/main/php/peer/ftp/server/FtpProtocol.class.php:667:    } ensure($e); {
../ftp/src/main/php/peer/ftp/server/FtpProtocol.class.php:718:    } ensure($e); {
../rdbms/src/main/php/rdbms/mssql/MsSQLDBAdapter.class.php:252:    } ensure($e); {
../rdbms/src/main/php/rdbms/mssql/MsSQLDBAdapter.class.php:273:    } ensure($e); {
../rdbms/src/main/php/rdbms/sybase/SybaseDBAdapter.class.php:272:    } ensure($e); {
../rdbms/src/main/php/rdbms/sybase/SybaseDBAdapter.class.php:293:    } ensure($e); {
../rdbms/src/test/php/rdbms/unittest/CriteriaTest.class.php:322:    } ensure($e); {

thekid added a commit to xp-framework/ftp that referenced this pull request Dec 20, 2015
thekid added a commit to xp-lang/compiler that referenced this pull request Dec 20, 2015
@thekid thekid closed this Dec 20, 2015
@thekid thekid deleted the rfc/remove-ensure branch December 20, 2015 18:20
@thekid thekid restored the rfc/remove-ensure branch December 20, 2015 18:20
@thekid thekid reopened this Dec 20, 2015
@thekid
Copy link
Member Author

thekid commented Dec 20, 2015

Compatibility

All libraries above have been adjusted accordingly and released with a patch-level release:

thekid added a commit that referenced this pull request Dec 20, 2015
@thekid thekid merged commit a382731 into xp-framework:master Dec 20, 2015
@thekid thekid deleted the rfc/remove-ensure branch December 20, 2015 19:48
thekid added a commit that referenced this pull request Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant