This repository has been archived by the owner on Sep 9, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Yield from #42
Open
thekid
wants to merge
13
commits into
master
Choose a base branch
from
feature/yield-from
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yield from #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails on HHVM: https://travis-ci.org/xp-lang/compiler/jobs/81253540: HHVM$recv= (yield $next); // Fatal error: syntax error, unexpected T_YIELD
$recv= yield $next; // Still doesn't work but at least parses! PHP$recv= (yield $next); // Works as expectred
$recv= yield $next; // Parse error (syntax error, unexpected '$next' (T_VARIABLE)) _Argl 😱_ - see also facebook/hhvm#1627 |
This is a terrible hack involving eval(), but the best I could find at the moment. If we found a place for one-time initialization code, we could include differing implementations there.
Choosing emitter based on PHP runtime version has also been applied to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements
yield from
as described in this PHP 7.0 RFC in both PHP and XP and makes it work in PHP >= 5.5