No support for XP 5.x

[thekid]

It should be decided whether to support XP 5.x.

Seems like a rather minimal change:

• In addition to class-main.php, search for class.php
• Don't encode arguments
• Encode output w/ iso-8859-1 instead of utf-8

[thekid]

Committed to the branch feature/support-xp5. For a comparison, see https://github.com/xp-runners/reference/compare/feature/support-xp5

[thekid]

Situation before:

Timm@slate ~
$ XP_RT=5.6 USE_XP=devel/xp-5x/core xp -v
Uncaught exception: Exception ([bootstrap] Cannot determine boot class path from ...)

Situation after:

Timm@slate ~
$ XP_RT=5.6 USE_XP=devel/xp-5x/core xp -v
XP 5.12.0-dev { PHP 5.6.16 & ZE 2.6.0 } @ Windows NT SLATE 10.0 build 10586 (Windows 10) i586
Copyright (c) 2001-2013 the XP group
FileSystemCL<...\xp-5x\core\src\main\php\>
FileSystemCL<...\xp-5x\core\src\main\resources\>
FileSystemCL<...\xp-5x\core\src\test\php\>
FileSystemCL<...\xp-5x\core\src\test\resources\>
FileSystemCL<C:\tools\cygwin\home\Timm\>

Encoding

Timm@slate ~
$ XP_RT=5.6 USE_XP=devel/xp-5x/core xp -w '$argv[1]." => ".urlencode($argv[1])' Wörld
Wörld => W%F6rld

Timm@slate ~
$ XP_RT=5.6 USE_XP=devel/xp/core xp -w '$argv[1]." => ".urlencode($argv[1])' Wörld
Wörld => W%C3%B6rld

[thekid]

The patch is indeed quite short (+61 −17), so maybe this is not a black and white decision, but maybe boils down to this:

The first public release of the new runners (at the time of writing, this would be 7.0.0) still has support for this but it's officially deprecated and to be removed in the next major.... - how's that?

[thekid]

how's that?

👍