Add not matching emoji test, and return empty array

xplorer-io · Jul 29, 2023 · c0cd043 · c0cd043
1 parent 27c01c2
commit c0cd043
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/src/emojis/emojiHandler.test.ts b/src/emojis/emojiHandler.test.ts
@@ -6,22 +6,33 @@ const emojis = {
     programming: ["javascript", "python"],
 };
 
-describe("Emoji handler", () => {
-    it("should return matching emojis for a given keyword", () => {
-        const keywords = Object.values(emojis).flat();
+const keywords = Object.values(emojis).flat();
 
+describe("Emoji handler", () => {
+    it("should return matching emoji for a given keyword", () => {
         const matchingEmojis = findMatchingEmojiKeywords(
             keywords,
             "reactivity",
             emojis
         );
         expect(matchingEmojis).toEqual(["react"]);
+    });
 
-        const matchingEmojis2 = findMatchingEmojiKeywords(
+    it("should return multiple matching emojis for a given keyword", () => {
+        const matchingEmojis = findMatchingEmojiKeywords(
             keywords,
             "javascript",
             emojis
         );
-        expect(matchingEmojis2).toEqual(["javascript", "programming"]);
+        expect(matchingEmojis).toEqual(["javascript", "programming"]);
+    });
+
+    it("should return empty array for a not matching keyword", () => {
+        const matchingEmojis = findMatchingEmojiKeywords(
+            keywords,
+            "random",
+            emojis
+        );
+        expect(matchingEmojis).toEqual([]);
     });
 });
diff --git a/src/emojis/emojiHandler.ts b/src/emojis/emojiHandler.ts
@@ -6,13 +6,7 @@ export function getEmojisToReactWith(text: string): Array<string> {
     const keywords = Object.values(emojis).flat();
 
     // search for each keyword in the text
-    const emojisToReactWith = findMatchingEmojiKeywords(
-        keywords,
-        lowerCaseText,
-        emojis
-    );
-
-    return Array.from(new Set(emojisToReactWith));
+    return findMatchingEmojiKeywords(keywords, lowerCaseText, emojis);
 }
 
 export function findMatchingEmojiKeywords(
@@ -31,4 +25,5 @@ export function findMatchingEmojiKeywords(
             return matchingEmojis;
         }
     }
+    return [];
 }