Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: some tracks show blank high-resolution waveform in 3.x #101

Closed
mr-smidge opened this issue Jul 12, 2023 · 3 comments
Closed

Bug: some tracks show blank high-resolution waveform in 3.x #101

mr-smidge opened this issue Jul 12, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mr-smidge
Copy link
Contributor

Overview

When exporting as library versions 2.x or 3.x, some tracks do not show any high-resolution waveform on Denon hardware. Note that the high-res waveform is generated on-the-fly by DJ hardware - it is not stored or written by libdjinterop. Instead, there must be something about the exports written by libdjinterop that confuse the player and result in no waveform being generated.

Acceptance Criteria

  • The above issue must be fixed.
@mr-smidge mr-smidge added the bug Something isn't working label Jul 12, 2023
@mr-smidge
Copy link
Contributor Author

mr-smidge commented Jul 12, 2023

Sample tracks that can reliably replicate this issue have been provided (to me), but for obvious reasons are not uploaded publically on this issue.

@mr-smidge mr-smidge self-assigned this Jul 12, 2023
@mr-smidge
Copy link
Contributor Author

Initial testing suggests that the bug is caused by the library using the older V1 encoding of the trackData field, instead of the new (backwards-incomaptible) V2 encoding. I clearly didn't notice this when doing the initial V2 implementation.

However, there are some residual lssues where the high-res waveform doesn't quite line up with the actual beat data... Will continue investigations.

@mr-smidge
Copy link
Contributor Author

PR #102 resolves this by upgrading to the V2 track data format, yay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant