Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve extra data when encoding/decoding Engine blobs #102

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Preserve extra data when encoding/decoding Engine blobs #102

merged 3 commits into from
Aug 12, 2023

Conversation

mr-smidge
Copy link
Contributor

@mr-smidge mr-smidge commented Aug 12, 2023 •
edited
Loading

  • Change encoded blob representation to std::byte rather than char.
  • Preserve extra binary data when decoding/encoding blobs. This can help with compatibility of future versions, as mentioned in Consider loading future-versioned databases #99.
  • Fix some string-rendering typos.
  • Update the track data format to the new "v2" arrangement, which is backwards-incompatible with v1.
  • Always set the cue point to be "adjusted" in the high-level API, as otherwise hardware players will default to their own derived one.

@mr-smidge mr-smidge self-assigned this Aug 12, 2023
@mr-smidge mr-smidge merged commit 6099928 into main Aug 12, 2023
2 checks passed
@mr-smidge mr-smidge mentioned this pull request Aug 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mr-smidge mr-smidge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mr-smidge