Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Docker image locally when running make run #28

Closed
xserrat opened this issue Jan 4, 2023 · 0 comments · Fixed by #29
Closed

Build Docker image locally when running make run #28

xserrat opened this issue Jan 4, 2023 · 0 comments · Fixed by #29
Assignees
@xserrat
Labels
enhancement New feature or request

Comments

@xserrat
Copy link
Owner

xserrat commented Jan 4, 2023

Due to the Docker image allocated in DockerHub is not updated automatically based on the Dockerfile changes (waiting for #27), we need a fallback to build the image manually without running make build (discussed here).
@xserrat xserrat added the enhancement New feature or request label Jan 4, 2023
@xserrat xserrat self-assigned this Jan 4, 2023
xserrat added a commit that referenced this issue Jan 4, 2023
@xserrat
[#28] Build Docker image locally when running make run
c99610c 
- Add .SILENT to each target to do not print the executed command
@xserrat xserrat mentioned this issue Jan 4, 2023
Merged
xserrat added a commit that referenced this issue Jan 4, 2023
@xserrat
[#28] Build Docker image locally when running make run
95cc604 
- Add .SILENT to each target to do not print the executed command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xserrat xserrat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#28] Build Docker image locally when running make run xserrat/docker-facebook-demucs
1 participant
@xserrat