Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark "builtin" as foreign #123

Merged
merged 1 commit into from
Aug 4, 2024
Merged

mark "builtin" as foreign #123

merged 1 commit into from
Aug 4, 2024

Conversation

skaji
Copy link
Member

@skaji skaji commented Aug 2, 2024

On perl 5.40.0, Scalar::Util 1.64, some tests fail:

#   Failed test at t/001_mouse/034-apply_all_roles.t line 43.
#          got: 'bar,blessed,foo,meta,method'
#     expected: 'bar,foo,meta,method'
# Looks like you failed 1 test of 9.

This is because, on perl 5.40.0, Scalar::Util 1.64,
the "blessed" function actually comes from "builtin" package.
https://metacpan.org/release/PEVANS/Scalar-List-Utils-1.64/source/lib/Scalar/Util.pm#L26-37

So we should mark "builtin" as foreign.

Base automatically changed from github-action to master August 4, 2024 11:30
@skaji skaji merged commit 59f5227 into master Aug 4, 2024
28 checks passed
@skaji skaji deleted the perl-5.40-scalar-util-1.64 branch August 4, 2024 11:30
skaji added a commit that referenced this pull request Aug 4, 2024
Changelog diff is:

diff --git a/Changes b/Changes
index 7db5730..c158494 100644
--- a/Changes
+++ b/Changes
@@ -1,7 +1,10 @@
 Revision history for Mouse
 
 {{$NEXT}}
-    - Use Devel-PPPort 3.59
+
+v2.5.11 2024-08-04T11:38:02Z
+    - Use Devel-PPPort 3.59 (atoomic #113)
+    - Mark "builtin" as foreign (#123)
 
 v2.5.10 2020-03-28T13:15:57Z
     - Do not use Fatal (#108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants