-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed failing test xinfo
on clang 16
#2740
Conversation
@tdegeus can I get your opinion on this PR? We collaborated on the original CI setup (Thanks again). I'd like to narrow the CI configurations and then expand only once we get things passing. |
Hi. Thanks! Shouldn't we better fix our issue? |
In the worse case we could even disable that one test on clang16 with a comment/warning. It is a convenience function anyway, so it's not too bad if it fails |
@tdegeus I like this. I will revise. I agree fixing the issue would be best but until someone finds the bandwidth to look into it, I think it's best to exclude the failing test so we don't inadvertently introduce additional failures. |
Great. We can just add a preprocessor statement and a reference to #2694 |
@tdegeus I cannot reproduce the failure on windows. It must be an issue with the pre-processor statement but using my windows clang set up it properly skips the test as expected. Do you see an immediate problem? |
Looks like it's a different test failing on windows I'll have to find that later |
Hi! Sorry, I thought that you gave up for today. Let's see what this gives! |
It seems that you're proving why it's not good to work with failing CI ;) |
Should we debug in a separate PR? |
xinfo
on clang 16
Cool now we only need to find one more test |
Checklist
Description
Following up on some previous work. I've removed clang 16 from the CI package as having failing tests all the time reduces the usefulness of the CI builds. Once XTensor irons out the bugs captured here: #2703 we can add it back.