Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reshape_view accept -1 as a wildcard dimension #2746

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Make reshape_view accept -1 as a wildcard dimension #2746

merged 6 commits into from
Nov 16, 2023

Commits on Nov 15, 2023

  1. Added dimension deduction for -1 shape parameters

    @spectre-ns
    spectre-ns committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e823ea6 View commit details
    Browse the repository at this point in the history

  2. Update include/xtensor/xstrided_view.hpp 

    Co-authored-by: Tom de Geus <[email protected]>
    @spectre-ns @tdegeus
    spectre-ns and tdegeus authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a35b0a2 View commit details
    Browse the repository at this point in the history

  3. Addressed comments

    @spectre-ns
    spectre-ns committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4e67be4 View commit details
    Browse the repository at this point in the history

  4. Ran pre-commit

    @spectre-ns
    spectre-ns committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d0506d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Addressed comments

    @spectre-ns
    spectre-ns committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    444dbe5 View commit details
    Browse the repository at this point in the history

  2. Specialized for fixed_shape<t>

    @spectre-ns
    spectre-ns committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    aaa819e View commit details
    Browse the repository at this point in the history