Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispose/destroy are used in various places to mean the same thing #1370

Closed
Tyriar opened this issue Apr 4, 2018 · 0 comments
Closed

dispose/destroy are used in various places to mean the same thing #1370

Tyriar opened this issue Apr 4, 2018 · 0 comments
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 4, 2018 •
edited
Loading

I suggest we standardize on "dispose" for such methods (and deprecate Terminal.destroy #1371).
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Apr 4, 2018
@Tyriar Tyriar mentioned this issue Apr 4, 2018
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 4, 2018
@Tyriar
Remove terminal references on dispose
e5ee76d 
Part of xtermjs#1341
Fixes xtermjs#1370
@Tyriar Tyriar mentioned this issue Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar