-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable absolute imports and minify distributable #2132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to figure out how to resolve the paths for the tests. |
Doesn't add much or tell the full story now with the integration tests
And so it begins. |
Tyriar
added a commit
to Tyriar/xterm.js
that referenced
this pull request
May 31, 2019
No longer needed after webpack refactor Missed in xtermjs#2132
This was referenced May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
Fixes #1254
This PR seems like a good place to start to move to v4 as it solves a bunch of problems and will let us remove the browserify build step as it works in
lib/
now. If you want to review alt+click the collapse button in GitHub to collapse all files and then ignore all files insidesrc/
except fortsconfig.json
.It makes the following high-level changes:
baseUrl
andpaths
intsconfig.json
for all paths referencingcommon
,core
andui
modules:out/
, this is no longer suitable to directly import because the absolute paths need to be packaged.out/
as a production umd module inlib/
, this is the newmain
file in `package.jsonout/
by default but can import fromlib/
by just uncommenting a line to verify the packaged portion (it requires you to runyarn package
though):css/
, removed tasks for move it aroundFollow up changes after this look good:
src/addons
and all build steps completelyNotes: