Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: handle input from macOS and Windows emoji panels #3429

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

Eugeny
Copy link
Member

@Eugeny Eugeny commented Aug 22, 2021

Adds an input event listener to the textarea to handle emoji IME events.
Closes #469. Tested on Windows and macOS

@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2021

FWIW Windows already seems to work fine for me as long as you're using wsl

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! One of the top voted issues done 🎉

@Tyriar Tyriar added this to the 4.14.0 milestone Aug 30, 2021
@Tyriar Tyriar merged commit fb43ff7 into xtermjs:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support emoji IMEs
2 participants