Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throughput performance improvements #3452

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Throughput performance improvements #3452

merged 5 commits into from
Sep 2, 2021

Commits on Sep 1, 2021

  1. Cache a copy of the active buffer as a private prop 

    This reduces GC from the const buffer workaround that avoids excessive getter access
with far less getter access

Part of xtermjs#3450
    @Tyriar
    Tyriar committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cece3db View commit details
    Browse the repository at this point in the history

  2. Avoid property use and float->number conversion

    @Tyriar
    Tyriar committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ffef3db View commit details
    Browse the repository at this point in the history

  3. Avoid scrollTop call in hot code 

    This seems to have been added in f6d5abf but it's not clear why, scroll APIs
seem to work fine without it and using a DOM API here is causing slowness
    @Tyriar
    Tyriar committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    263c6d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Merge branch 'master' into perf_fixes

    @Tyriar
    Tyriar authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    a649192 View commit details
    Browse the repository at this point in the history

  2. Fire buffer activate event on buffer service reset

    @Tyriar
    Tyriar committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    20460a2 View commit details
    Browse the repository at this point in the history