Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3348 #3454

Merged
merged 2 commits into from
Sep 1, 2021
Merged

fix #3348 #3454

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c8f600
fix #3348
meganrogge Sep 1, 2021
199e477
3 -> 1 line
meganrogge Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion addons/xterm-addon-webgl/src/WebglRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ export class WebglRenderer extends Disposable implements IRenderer {
for (const l of this._renderLayers) {
l.dispose();
}
this._core.screenElement!.removeChild(this._canvas);
if (this._canvas.parentNode) {
this._core.screenElement?.removeChild(this._canvas);
}
meganrogge marked this conversation as resolved.
Show resolved Hide resolved
super.dispose();
}

Expand Down