-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Add support for exporting decoded logs as a file. #72
Conversation
Co-authored-by: Junhao Liao <[email protected]>
…ogs to utils folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Let's address the final comments.
Co-authored-by: Junhao Liao <[email protected]>
How about changing the PR title to
|
…filename class to CSS.
…xportProgress." This reverts commit 1e99e07.
I agree with Kirk's proposal of the PR title. |
References
Description
Add "Export Logs" button to download the current uncompressed logs.
The button triggers
exportLogs
function defined inStateContextProvider
, which posts aEXPORT_LOG
worker request toMainWorker
. The worker parses log events into chunks inloadChunk
and postsCHUNK_DATA
responses back toStateContextProvider
. It appends the posted log chunk usinglogExportManager
, which triggers a download when it receives all log chunks.Validation performed
Click download button, the logs are downloaded with timestamped fileNames. Click download button multiple times, the logs are downloaded with different timestamps.