Refine the group value comparison in get_mut()

yahoNanJing · Jul 17, 2023 · a18ac07 · a18ac07
1 parent f40a842
commit a18ac07
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/datafusion/core/src/physical_plan/aggregates/row_hash.rs b/datafusion/core/src/physical_plan/aggregates/row_hash.rs
@@ -431,14 +431,17 @@ impl GroupedHashAggregateStream {
 
         match self.row_converter.get_row_width() {
             Some(row_width) if row_width <= VALUE_EMBEDDED_WIDTH_THRESHOLD => {
+                let mut padded_group_value = [0u8; VALUE_EMBEDDED_WIDTH_THRESHOLD];
                 for (row, &hash) in batch_hashes.iter().enumerate() {
                     let entry = self.value_embedded_map.get_mut(
                         hash,
                         |(_hash, _group_idx, padded_value)| {
                             // verify that a group that we are inserting with hash is
                             // actually the same key value as the group in
                             // existing_idx  (aka group_values @ row)
-                            group_rows.row_data(row) == &padded_value[0..row_width]
+                            padded_group_value[0..row_width]
+                                .copy_from_slice(group_rows.row_data(row));
+                            padded_group_value == *padded_value
                         },
                     );