Skip to content

Commit

Permalink
Restore unused block warnings condition for Ruby 3.4
Browse files Browse the repository at this point in the history
ruby/ruby#10403 raised many "the block passed to" warnings.
then idnored these warnings because some of them might have contain false positives.

Now we can restore the warning condition
because these false positives should have been addressed by these changes:

ruby/ruby#10559
rails#51597
rails#51583
  • Loading branch information
yahonda committed May 17, 2024
1 parent 965b8c3 commit cba2b2f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions activesupport/lib/active_support/testing/strict_warnings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ class WarningError < StandardError; end
# Expected non-verbose warning emitted by Rails.
/Ignoring .*\.yml because it has expired/,
/Failed to validate the schema cache because/,

# Ref: https://bugs.ruby-lang.org/issues/15554
# This new Ruby 3.4 warning is still being fined tuned to reduce false positives
/the block passed to/,
)

SUPPRESSED_WARNINGS = Regexp.union(
Expand Down

0 comments on commit cba2b2f

Please sign in to comment.