Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update so that it actually builds. #16

Open
wants to merge 4 commits into
base: hpack-convert
Choose a base branch
from

Conversation

kindaro
Copy link

@kindaro kindaro commented Feb 1, 2018

  • Advance stack snapshot version.
  • Fix the breakage caused by changes in Cabal.
  • Bump minor version.

This still leaves many warnings to be addressed. Only erroneous faults
were fixed due to urgency.

* Advance stack snapshot version.
* Fix the breakage caused by changes in Cabal.
* Bump minor version.

This still leaves many warnings to be addressed. Only erroneous faults
were fixed due to urgency.
@simonmichael
Copy link

Ping. Thanks for hpack-convert, could this fix be released ?

@hiratara
Copy link

I made a patch for building hpack-convert with LTS12.1 .

8695b56

@borkdude
Copy link

Running into this as well.

@@ -1,5 +1,4 @@
flags: {}
packages:
Copy link

@vyorkin vyorkin Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls correct me if I'm wrong, but I believe it should be:

packages: []

otherwise I got error:

Error while parsing $.library.dependencies -
expected Array, Object, or String, encountered Null
$ hpack --version
hpack version 0.28.2

@expipiplus1
Copy link

This works well for me, can it be merged?

Most of the changes are due to the Pretty class that was added, it
seems, in v2.2.0.1-tgt. There were some slightly trickier cases around
some data types that don't seem to be used anymore and changes to the
Package/ GenericPackge records.

Open questions:

- This doesn't pass all the tests. The main failures seem to be around
quoting in certain rendering situations and in error reporting
- Relatedly, how should the new-ish ParseResult monad be incorporated? I
opted for parseGenericPackageDescriptionMaybe because I didn't want to
infect the rest of the module with an API change, but it's unclear how
to exactly recover the old behavior.
- Is the style where it needs to be (whitespace/ indentation, ...)?
@wbadart
Copy link

wbadart commented Mar 28, 2020

Hey all, I just opened kindaro#1. Would love to discuss if any of you are still interested in this package as of 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants