Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsyaml build by replacing istanbul with istanbul-classic #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix jsyaml build by replacing istanbul with istanbul-classic #4

wants to merge 1 commit into from

Conversation

ingydotnet
Copy link
Member

No description provided.

@perlpunk
Copy link
Member

Thanks.
I'm still getting a deprecation warning:

+ cd js-yaml-3.13.1
+ perl -pi -e 's/"istanbul": "\^0\.4\.5",/"istanbul-classic": "^2019.8.9",/' package.json
+ npm install .
npm WARN deprecated [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.                                                      
npm WARN deprecated [email protected]: CircularJSON is in maintenance only, flatted is its successor.

Maybe we should just hope that the js-yaml package is fixed by the maintainers soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingydotnet @perlpunk