Iter1 #20
Open
Iter1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstet
reviewed
Oct 4, 2023
| return c.String(http.StatusUnprocessableEntity, "Invalid order") | ||
| } | ||
|
|
||
| // if !utils.Valid(order) { |
There was a problem hiding this comment.
Раскоменчу
При проверке тяжело было генерить подходящие под условие номера заказа
alekstet
reviewed
Oct 4, 2023
| func GetUserLoginFromToken(tokenString string) (string, error) { | ||
| claims := &Claims{} | ||
| _, err := jwt.ParseWithClaims(tokenString, claims, | ||
| func(t *jwt.Token) (interface{}, error) { |
There was a problem hiding this comment.
Вынеси это в отдельную функцию для простоты восприятия
alekstet
reviewed
Oct 4, 2023
| AccrualSys string `env:"FILE_STORAGE_PATH"` | ||
| } | ||
|
|
||
| var cfg AppConfig |
There was a problem hiding this comment.
А зачем глобальная переменная? Думаю стоит уйти от этого
alekstet
reviewed
Oct 4, 2023
| return c.String(http.StatusBadRequest, "Invalid request type") | ||
| } | ||
|
|
||
| _ = s.DB.First(&userDB, models.Users{Login: userReq.Login}) |
There was a problem hiding this comment.
Это возвращает ошибку? Если да, то надо обработать
alekstet
reviewed
Oct 4, 2023
| expiresTime := time.Now().Add(3 * time.Hour) | ||
| token, err := auth.GenerateToken(userDB) | ||
|
|
||
| if err != nil { |
alekstet
reviewed
Oct 4, 2023
|
|
||
| func (s *Server) GetOrderByParam(c echo.Context) error { | ||
| var order models.Orders | ||
| type Response struct { |
There was a problem hiding this comment.
Можно ли как то лаконичнее сделать все нужные мне структуры из файла models.go ?
Получается что часть из них повторяет поля друг друга, но называются по разному. Не хотелось там плодить одинаковые ответы. Можно ли как то это красивее сделать ?
alekstet
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.