Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 - Cinder volume attachment #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

axel3rd
Copy link
Collaborator

@axel3rd axel3rd commented Aug 3, 2018

Cf. #15, only one volume attachment for this first implementation.

Copy link
Collaborator Author

@axel3rd axel3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 1
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 0

See all issues in SonarCloud

*/
protected CreateImageOptions volume(@Nullable final String volume) {
if (StringUtil.isNotEmpty(volume)) {
String[] volumeNameDevice = volume.split(",");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug Bug: A "NullPointerException" could be thrown; "volume" is nullable here. (squid:S2259)

See it in SonarCloud

@axel3rd
Copy link
Collaborator Author

axel3rd commented Aug 3, 2018

cinder volume (v1) seems work on mitaka, but not pike.
cinder volume doesn't exist on mitaka.
=> Need to check if we can test & user most recent cinder version witj JClouds

@axel3rd
Copy link
Collaborator Author

axel3rd commented Aug 3, 2018

=> Need to check if we can test & user most recent cinder version witj JClouds

Nop, cinder v2 is not supported by JClouds JCLOUDS-1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant