Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite rollup: combined rules #4426

Merged
merged 8 commits into from
Mar 6, 2019

Conversation

Felixoid
Copy link
Member

@Felixoid Felixoid commented Feb 17, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Category:

  • New Feature

Short description:
Combine rules for graphite rollup from dedicated aggregation and retention patterns.

Detailed description:
Original whisper storage has separated aggregation and retention rules. This pull request implements the same way to configure GraphiteMergeTree.

@Felixoid
Copy link
Member Author

Felixoid commented Feb 18, 2019

Теперь для мерджа используется пара из двух паттернов, один из которых должен содержать retention и второй function параметры. Default также теперь может задавать только один из двух параметров.

Обратная совместимость полностью сохранена.

@Felixoid Felixoid force-pushed the graphite-rollup branch 2 times, most recently from 5a98de2 to 298d6f7 Compare February 21, 2019 09:58
@Felixoid Felixoid force-pushed the graphite-rollup branch 5 times, most recently from 485667e to a322b05 Compare February 25, 2019 15:59
@Felixoid Felixoid changed the title WIP: Graphite rollup Graphite rollup combined rules Feb 25, 2019
@Felixoid Felixoid closed this Feb 25, 2019
@Felixoid Felixoid deleted the graphite-rollup branch February 25, 2019 20:49
@Felixoid Felixoid restored the graphite-rollup branch February 25, 2019 21:06
@Felixoid Felixoid reopened this Feb 25, 2019
@Felixoid Felixoid changed the title Graphite rollup combined rules Graphite rollup: combined rules Feb 25, 2019
@Felixoid Felixoid force-pushed the graphite-rollup branch 3 times, most recently from 4a1e2c2 to ccfb94b Compare February 26, 2019 20:20
@Felixoid
Copy link
Member Author

Felixoid commented Mar 4, 2019

If this PR will be merged before #4584, then the second PR should adjust tests and fix conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants