-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite rollup: combined rules #4426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Теперь для мерджа используется пара из двух паттернов, один из которых должен содержать retention и второй function параметры. Default также теперь может задавать только один из двух параметров. Обратная совместимость полностью сохранена. |
Felixoid
force-pushed
the
graphite-rollup
branch
from
February 20, 2019 00:23
9c2aa6b
to
c66449d
Compare
Felixoid
commented
Feb 20, 2019
Felixoid
force-pushed
the
graphite-rollup
branch
from
February 20, 2019 09:48
c66449d
to
41167ca
Compare
Felixoid
force-pushed
the
graphite-rollup
branch
2 times, most recently
from
February 21, 2019 09:58
5a98de2
to
298d6f7
Compare
Felixoid
force-pushed
the
graphite-rollup
branch
5 times, most recently
from
February 25, 2019 15:59
485667e
to
a322b05
Compare
Felixoid
changed the title
Graphite rollup combined rules
Graphite rollup: combined rules
Feb 25, 2019
Felixoid
force-pushed
the
graphite-rollup
branch
3 times, most recently
from
February 26, 2019 20:20
4a1e2c2
to
ccfb94b
Compare
Felixoid
force-pushed
the
graphite-rollup
branch
from
February 27, 2019 12:59
ccfb94b
to
4cfe93a
Compare
If this PR will be merged before #4584, then the second PR should adjust tests and fix conflicts. |
This was referenced Mar 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category:
Short description:
Combine rules for graphite rollup from dedicated aggregation and retention patterns.
Detailed description:
Original whisper storage has separated aggregation and retention rules. This pull request implements the same way to configure GraphiteMergeTree.