🐛 fix breakage caused by new AWS Access Portal design #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS deployed progressively a new design for their AWS SSO Portal Page UI which breaks the parsing logic of this extension. In addition, the format of the connection URL for each target profile changed and doesn't include anymore the AWS account name information. This commit fixes the issues by adding new parser logic for the new layout. We still support the legacy AWS access portal as it might still be available for some customers. The new connection URL format is more tricky as the lack of account name information will cause the created container to contain the account id instead of the account name unless the user explicitly loaded the list of profile name from the portal page first (which should be the usual usage with this extension). There is no perfect solution for that issue, for now we fallback to displaying the account id instead of the account name. We might improve that later if we can get the account name information on the fly when the user went throught the SSO portal page before.
By using a class, we can now have better flexibility to implement the various attributes of an aws profile. In particular, `title` and `id` are now dynamically computed base on other attributes. It allows us to better support both the new and legacy aws portal layout, as we can have some case where we don't have the account name with the latter.
yannrouillard
force-pushed
the
fix/adapt-to-last-aws-console-update
branch
from
7af6119
to
10fdfed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS deployed progressively a new design for their AWS SSO Portal Page UI which breaks the parsing logic of this extension.
In addition, the format of the connection URL for each target profile changed and doesn't include anymore the AWS account name information.
This commit fixes the issues by adding new parser logic for the new layout. We still support the legacy AWS access portal as it might still be available for some customers.
The new connection URL format is more tricky as the lack of account name information will cause the created container to contain the account id instead of the account name unless the user explicitly loaded the list of profile name from the portal page first (which should be the usual usage with this extension).
There is no perfect solution for that issue, for now we fallback to displaying the account id instead of the account name. We might improve that later if we can get the account name information on the fly when the user went throught the SSO portal page before.