fix binding.gyp include_dir and add submodule-recursive in .github/wo…

…rkflows/test.yml
yanyiwu · Jul 16, 2024 · 70ed827 · 70ed827
1 parent 3ca3451
commit 70ed827
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -19,11 +19,12 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
+      with:
+        submodules: recursive
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
         cache: 'npm'
     - run: npm ci
-    - run: npm run build --if-present
     - run: npm test
diff --git a/binding.gyp b/binding.gyp
@@ -12,13 +12,17 @@
         "VCCLCompilerTool": { "ExceptionHandling": 1 },
       },
       "win_delay_load_hook": "true",
-      "sources": ["./lib/index.cpp", "./lib/nodejieba.cpp"],
+      "sources": [
+        "./lib/index.cpp", 
+	"./lib/nodejieba.cpp",
+      ],
       "cflags": [
         "-DLOGGING_LEVEL=LL_WARNING"
       ],
       "include_dirs" : [
         "<!(node -p \"require('node-addon-api').include_dir\")",
-        "./deps"
+        "./submodules/cppjieba/include",
+        "./submodules/cppjieba/deps/limonp/include",
       ],
       'configurations': {
         'Release': {