Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore mac arm64 build #46

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: restore mac arm64 build #46

merged 1 commit into from
Sep 16, 2024

Conversation

faulpeltz
Copy link

Switch macos arm64 to native build using macos-14 runner
Free up a bunch of disk space on the macos-14 runner before building, the build seems to take up at least ~30GB at peak

@@ -87,21 +87,20 @@ jobs:

# add missing distutils package to python 3.12
- name: Install distutils
run: brew install python-setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this working both for nodejs 18 and 20 as well? I remember that during build it complains about missing distutils

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because it didn't work on 18 with the old variant - maybe related to the runner change...

@robertsLando robertsLando changed the title switch to macos-14 runner and cleanup before build fix: restore mac arm64 build Sep 11, 2024
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Can I merge it?

@robertsLando robertsLando merged commit 75d4ca0 into yao-pkg:main Sep 16, 2024
4 checks passed
@robertsLando
Copy link
Member

@faulpeltz sorry missed your feedback here 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants