Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow undefined for optional arguments #6

Merged
merged 2 commits into from
Feb 9, 2017

Conversation

JaKXz
Copy link
Member

@JaKXz JaKXz commented Feb 9, 2017

Also add tests for using the arguments object. @bcoe if you could take a quick 👀 in post :)

Also add tests for using the arguments object
@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b22a697 on fix/allow-optional-undefined into 2548f57 on master.

const buffer = new Buffer('robin');
test('Function.prototype.apply with the arguments object', t => {
function foo () {
return argsert.apply(this, arguments);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoe so this is probably the way that yargs/yargs#773 would make use of this lib :)

@JaKXz JaKXz requested a review from bcoe February 9, 2017 06:59
@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4255f0e on fix/allow-optional-undefined into 2548f57 on master.

@JaKXz JaKXz merged commit 942da4f into master Feb 9, 2017
@JaKXz JaKXz deleted the fix/allow-optional-undefined branch February 9, 2017 21:58
@bcoe bcoe mentioned this pull request Feb 21, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants