[node-modules] Avoids recreating nm folders and only clears them #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
larixer
changed the title
larixer
force-pushed
the
top-level-nm-folders-keeping
branch
from
8a019ac
to
8a6ed8b
Compare
|
Looks fine! Can you just add a test, to make sure there are no regressions? |
|
Yes, sure, will do and let you know |
larixer
force-pushed
the
top-level-nm-folders-keeping
branch
from
c1bd0f5
to
6f17705
Compare
|
@arcanis Regression test has been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR solves issue: #1184
How did you fix it?
The linker does not attempt removing node_modules folders if it is going to recreate them soon.