Cleanup .bin folders from node_modules #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect 👍 Can you add a test in pnp.test.js? Cf the existing dot-folder test in the same file. |
|
@arcanis I have modified the test that already checked how node_modules is being cleared, I have added creation of |
larixer
commented
Apr 17, 2020
| @@ -1371,6 +1371,7 @@ describe(`Plug'n'Play`, () => { | |||
| test( | |||
| `it should remove lingering folders from the node_modules even when they contain dot-folders`, | |||
| makeTemporaryEnv({}, async ({path, run, source}) => { | |||
| await xfs.mkdirpPromise(`${path}/node_modules/.bin`); | |||
There was a problem hiding this comment.
this line was added to existing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Pnp linker cleans up all node_modules folders except dot folders inside them. This leaves out
.binfolders that are certainly not needed for pnp mode.How did you fix it?
Added removal of
.binentries insidenode_modulesas well.