Implement package search bar on docs website #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jul 1, 2019
larixer
force-pushed
the
site-search
branch
3 times, most recently
from
93b3a50
to
2fbe4ec
Compare
|
Nice! Maybe we could use the equivalent of |
|
@arcanis Yep, I agree. I don't like current logic of url replacement. It would be nice to simplify it |
|
Master is fixed! 👍 |
Yep, I saw in the chat :) and rebased already :) |
larixer
force-pushed
the
site-search
branch
2 times, most recently
from
51e94ca
to
521dbd0
Compare
arcanis
reviewed
Jul 23, 2019
| return ((href === '/' && ['/', '/package'].includes(location.pathname)) || | ||
| (href !== '/' && location.pathname.startsWith(href))) ? | ||
| { className: 'active' } : | ||
| null; |
There was a problem hiding this comment.
I'm not too sure I understand the intent here - might be worth a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds website package search bar, by porting yarn v1 search bar source code and upgrading it to use Hooks and Styled Components